|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH 14/30] target-i386: ICC bus: replace BusState.allow_hotplug with hotplug_handler |
| Date: | Wed, 24 Sep 2014 16:50:17 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 24/09/2014 16:37, Igor Mammedov ha scritto: >> > If you do this, aren't you enabling CPU hot-unplug? Should >> > hotplug_handler_plug and/or hotplug_handler_unplug return an error if >> > there is no callback? > hotplug/unplug of x86 CPU is not usable with device_add/del yet, so > it's not used for CPUs yet. > x86 CPU nor APIC don't have DeviceClass.unplug callback so for old > behavior any attempt to call device_del would cause abort. > With this path attempt would become NOP. Can you make it an error instead? I guess that's related to the other question---whether hotplug_handler_plug and/or hotplug_handler_unplug should return an error if there is no callback. Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |