[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/7] qdev: set the object property's description
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 5/7] qdev: set the object property's description to the qdev property's. |
Date: |
Tue, 23 Sep 2014 19:03:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 23/09/2014 15:08, address@hidden ha scritto:
> From: Gonglei <address@hidden>
>
> When we call qdev_alias_all_properties() adding alias properties to
> the source object all qdev properties on the target DeviceState,
> set the object property's description to the qdev property's.
>
> c: Paolo Bonzini <address@hidden>
> Cc: Michael S. Tsirkin <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
> hw/core/qdev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index fcb1638..61d352c 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -796,6 +796,9 @@ void qdev_alias_all_properties(DeviceState *target,
> Object *source)
> object_property_add_alias(source, prop->name,
> OBJECT(target), prop->name,
> &error_abort);
> + object_property_set_description(source, prop->name,
> + prop->info->description,
> + &error_abort);
Please do this directly in object_property_add_alias.
Paolo
> }
> class = object_class_get_parent(class);
> } while (class != object_class_by_name(TYPE_DEVICE));
>
- [Qemu-devel] [PATCH 0/7] add description field in ObjectProperty and PropertyInfo struct, arei.gonglei, 2014/09/23
- [Qemu-devel] [PATCH 7/7] qdev: drop legacy_name from qdev properties, arei.gonglei, 2014/09/23
- [Qemu-devel] [PATCH 4/7] qom: add description field in ObjectProperty struct, arei.gonglei, 2014/09/23
- [Qemu-devel] [PATCH 5/7] qdev: set the object property's description to the qdev property's., arei.gonglei, 2014/09/23
- Re: [Qemu-devel] [PATCH 5/7] qdev: set the object property's description to the qdev property's.,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 5/7] qdev: set the object property's description to the qdev property's., Gonglei (Arei), 2014/09/23
- Re: [Qemu-devel] [PATCH 5/7] qdev: set the object property's description to the qdev property's., Paolo Bonzini, 2014/09/24
- Re: [Qemu-devel] [PATCH 5/7] qdev: set the object property's description to the qdev property's., Gonglei (Arei), 2014/09/24
- Re: [Qemu-devel] [PATCH 5/7] qdev: set the object property's description to the qdev property's., Gonglei (Arei), 2014/09/24
- Re: [Qemu-devel] [PATCH 5/7] qdev: set the object property's description to the qdev property's., Paolo Bonzini, 2014/09/24
[Qemu-devel] [PATCH 6/7] qmp: print descriptions of object properties, arei.gonglei, 2014/09/23
[Qemu-devel] [PATCH 2/7] qom: add error handler for object alias property, arei.gonglei, 2014/09/23
[Qemu-devel] [PATCH 1/7] qom: add error handler for object_property_print(), arei.gonglei, 2014/09/23
[Qemu-devel] [PATCH 3/7] qdev: add description field in PropertyInfo struct, arei.gonglei, 2014/09/23