[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in m
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge |
Date: |
Thu, 18 Sep 2014 16:13:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 05/09/2014 18:51, Peter Lieven ha scritto:
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> block.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/block.c b/block.c
> index fa4c34b..db3f842 100644
> --- a/block.c
> +++ b/block.c
> @@ -4554,6 +4554,11 @@ static int multiwrite_merge(BlockDriverState *bs,
> BlockRequest *reqs,
> merge = 0;
> }
>
> + if (bs->bl.max_transfer_length && reqs[outidx].nb_sectors +
> + reqs[i].nb_sectors > bs->bl.max_transfer_length) {
> + merge = 0;
> + }
> +
> if (merge) {
> size_t size;
> QEMUIOVector *qiov = g_malloc0(sizeof(*qiov));
>
So I think if we treat it just as a hint for multiwrite, we can avoid
writing code to split oversized requests. They always worked so far, we
can certainly wait until we have a real bugfix.
Can you drop patch 2 and resend the rest?
Thanks,
Paolo
- Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests, (continued)
- Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests, Peter Lieven, 2014/09/08
- Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests, Paolo Bonzini, 2014/09/08
- Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests, Peter Lieven, 2014/09/12
- Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests, Paolo Bonzini, 2014/09/18
- Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests, Peter Lieven, 2014/09/18
- Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests, Paolo Bonzini, 2014/09/18
- Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests, Peter Lieven, 2014/09/18
- Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests, Peter Lieven, 2014/09/08
[Qemu-devel] [PATCH 3/4] block/iscsi: set max_transfer_length, Peter Lieven, 2014/09/05
[Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge, Peter Lieven, 2014/09/05
- Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge, Peter Lieven, 2014/09/18
- Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge, Paolo Bonzini, 2014/09/19
- Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge, Peter Lieven, 2014/09/22
- Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge, Paolo Bonzini, 2014/09/22
- Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge, Peter Lieven, 2014/09/23
- Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge, Kevin Wolf, 2014/09/23
- Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge, Peter Lieven, 2014/09/23
- Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge, Peter Lieven, 2014/09/23
- Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge, Kevin Wolf, 2014/09/23
- Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge, Peter Lieven, 2014/09/23