[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/19] dev-serial: convert init to realize
From: |
Gonglei (Arei) |
Subject: |
Re: [Qemu-devel] [PATCH v2 12/19] dev-serial: convert init to realize |
Date: |
Thu, 18 Sep 2014 13:26:45 +0000 |
> From: Paolo Bonzini [mailto:address@hidden
> Sent: Thursday, September 18, 2014 8:59 PM
> Subject: Re: [PATCH v2 12/19] dev-serial: convert init to realize
>
> Il 18/09/2014 14:47, address@hidden ha scritto:
> > if (s->cs->be_open && !dev->attached) {
> > - usb_device_attach(dev, &local_err);
> > - if (local_err) {
> > - qerror_report_err(local_err);
> > - error_free(local_err);
> > - }
> > + usb_device_attach(dev, errp);
> > }
> > - return 0;
>
> Subtle change: realize now fails if the attach fails, i.e. if the speed
> is mismatched. This is a bugfix, but it doesn't happen if the backend
> is closed (e.g. for server socket chardevs).
>
Yes. Good catch. :)
> For a follow-up, the speed check could be extracted to a separate
> function usb_check_attach, that is called just once at realize time,
> even if !s->cs->be_open. Then, I think, all calls to usb_device_attach
> in dev-serial can pass &error_abort.
>
Yes, we can.
Can we use qerror_report_err still in realize function?
Just report this error but not propagate to the caller. Thanks!
Best regards,
-Gonglei
- [Qemu-devel] [PATCH v2 03/19] usb-net: convert init to realize, (continued)
- [Qemu-devel] [PATCH v2 03/19] usb-net: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 09/19] dev-uas: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 06/19] usb-hub: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 07/19] dev-storage: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 08/19] dev-storage: usring error_report instead of fprintf/printf, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 02/19] usb-bus: convert USBDeviceClass init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 10/19] dev-uas: using error_report instead of fprintf, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 11/19] dev-bluetooth: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 12/19] dev-serial: convert init to realize, arei.gonglei, 2014/09/18
[Qemu-devel] [PATCH v2 13/19] usb-ccid: convert init to realize, arei.gonglei, 2014/09/18
[Qemu-devel] [PATCH v2 05/19] libusb: using error_report instead of fprintf, arei.gonglei, 2014/09/18
[Qemu-devel] [PATCH v2 15/19] dev-wacom: convert init to realize, arei.gonglei, 2014/09/18
[Qemu-devel] [PATCH v2 14/19] dev-hid: convert init to realize, arei.gonglei, 2014/09/18