[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/19] usb-audio: convert init to realize
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 16/19] usb-audio: convert init to realize |
Date: |
Thu, 18 Sep 2014 12:16:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 18/09/2014 11:32, address@hidden ha scritto:
> From: Gonglei <address@hidden>
>
> Signed-off-by: Gonglei <address@hidden>
> ---
> hw/usb/dev-audio.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c
> index 7b9957b..83ebe83 100644
> --- a/hw/usb/dev-audio.c
> +++ b/hw/usb/dev-audio.c
> @@ -628,7 +628,7 @@ static void usb_audio_handle_destroy(USBDevice *dev)
> streambuf_fini(&s->out.buf);
> }
>
> -static int usb_audio_initfn(USBDevice *dev)
> +static void usb_audio_realize(USBDevice *dev, Error **errp)
> {
> USBAudioState *s = DO_UPCAST(USBAudioState, dev, dev);
>
> @@ -651,7 +651,6 @@ static int usb_audio_initfn(USBDevice *dev)
> s, output_callback, &s->out.as);
> AUD_set_volume_out(s->out.voice, s->out.mute, s->out.vol[0],
> s->out.vol[1]);
> AUD_set_active_out(s->out.voice, 0);
> - return 0;
> }
>
> static const VMStateDescription vmstate_usb_audio = {
> @@ -676,7 +675,7 @@ static void usb_audio_class_init(ObjectClass *klass, void
> *data)
> set_bit(DEVICE_CATEGORY_SOUND, dc->categories);
> k->product_desc = "QEMU USB Audio Interface";
> k->usb_desc = &desc_audio;
> - k->init = usb_audio_initfn;
> + k->realize = usb_audio_realize;
> k->handle_reset = usb_audio_handle_reset;
> k->handle_control = usb_audio_handle_control;
> k->handle_data = usb_audio_handle_data;
>
Reviewed-by: Paolo Bonzini <address@hidden>
- [Qemu-devel] [PATCH 18/19] usb-mtp: convert init to realize, (continued)
- [Qemu-devel] [PATCH 18/19] usb-mtp: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 19/19] usb-bus: remove "init" from USBDeviceClass struct, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 13/19] usb-ccid: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 14/19] dev-hid: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 16/19] usb-audio: convert init to realize, arei.gonglei, 2014/09/18
- Re: [Qemu-devel] [PATCH 16/19] usb-audio: convert init to realize,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 15/19] dev-wacom: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 09/19] dev-uas: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 05/19] libusb: using error_report instead of fprintf, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 11/19] dev-bluetooth: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 17/19] usb-redir: convert init to realize, arei.gonglei, 2014/09/18