Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

[Markus Armbruster]

Gerd Hoffmann <address@hidden> writes:

>   Hi,
>
>> > Gonglei (2):
>> >   redirect.c: Don't use qerror_report()
>> >   dev-network: Don't use qerror_report_err()
>
>> Hi, Gerd 
>> Would you like to apply this patch series at present? Thanks!
>
> Picked it up now.  Originally dropped due to review comments from paolo,
> but switching all usb over to realize is a bigger project indeed.

Please don't, it degrades QMP errors.  Example:

    { "execute": "device_add", "arguments": { "driver": "usb-redir" } }

Reply before:

    {"error": {"class": "GenericError", "desc": "Parameter 'chardev' is 
missing"}}

After:

    {"error": {"class": "GenericError", "desc": "Device initialization 
failed."}}

with "Parameter 'chardev' is missing" barfed to stderr.