[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty
From: |
Marcelo Tosatti |
Subject: |
Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty |
Date: |
Tue, 16 Sep 2014 12:55:26 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Sep 16, 2014 at 05:42:16PM +0200, Paolo Bonzini wrote:
> Il 16/09/2014 17:14, Marcelo Tosatti ha scritto:
> > + /*
> > + * Make sure that CPU state is synchronized from KVM
> > + * once every VM state change callback has finished.
>
> Which other callback could affect the in-kernel state,
Marcin mentioned that APIC state was the culprit.
Perhaps
bdrv_drain_all();
ret = bdrv_flush_all();
Can change the interrupt state ?
Then that should read "once VM stop has finished".
> call cpu_clean_all_dirty instead?
>
> Paolo
>
> > + */
> > cpu_clean_all_dirty();
- [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty, Marcelo Tosatti, 2014/09/16
- Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty, Paolo Bonzini, 2014/09/16
- Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty,
Marcelo Tosatti <=
- Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty, Paolo Bonzini, 2014/09/16
- Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty, Marcelo Tosatti, 2014/09/16
- Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty, Paolo Bonzini, 2014/09/16
- Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty, Marcelo Tosatti, 2014/09/16
- Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty, Marcelo Tosatti, 2014/09/16
- Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty, Marcelo Tosatti, 2014/09/16
Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty, Marcelo Tosatti, 2014/09/16