[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 06/23] block: Make BlockBackend own its Block
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH v2 06/23] block: Make BlockBackend own its BlockDriverState |
Date: |
Tue, 16 Sep 2014 12:56:44 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
> /* blkdev->bs is not create by us, we get a reference
> * so we can bdrv_unref() unconditionally */
> - bdrv_ref(blkdev->bs);
> + /* Except we don't bdrv_unref() anymore, we blk_unref().
Is this dot extra ? ^
The following line seems to make better sense without this dot and the initial
cap.
> + * Conditionally, because we can't easily blk_ref() here.
> @@ -712,9 +711,7 @@ static int img_check(int argc, char **argv)
>
> fail:
> qapi_free_ImageCheck(check);
> - bdrv_unref(bs);
> blk_unref(blk);
> -
Spurious blank line removal here.
> @@ -483,9 +481,6 @@ int main(int argc, char **argv)
> */
> bdrv_drain_all();
>
> - if (qemuio_bs) {
> - bdrv_unref(qemuio_bs);
> - }
> blk_unref(qemuio_blk);
> g_free(readline_state);
> return 0;
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index fa8a7d0..0c496af 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -771,7 +771,6 @@ int main(int argc, char **argv)
Well that does seems to simplify things a lot.
- Re: [Qemu-devel] [PATCH v2 03/23] block: Connect BlockBackend to BlockDriverState, (continued)
- [Qemu-devel] [PATCH v2 12/23] virtio-blk: Drop redundant VirtIOBlock member conf, Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 13/23] virtio-blk: Rename VirtIOBlkConf variables to conf, Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 01/23] block: Split bdrv_new_root() off bdrv_new(), Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 06/23] block: Make BlockBackend own its BlockDriverState, Markus Armbruster, 2014/09/13
- Re: [Qemu-devel] [PATCH v2 06/23] block: Make BlockBackend own its BlockDriverState,
Benoît Canet <=
- [Qemu-devel] [PATCH v2 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo(), Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 07/23] block: Eliminate bdrv_iterate(), use bdrv_next(), Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 05/23] block: Code motion to get rid of stubs/blockdev.c, Markus Armbruster, 2014/09/13