[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [virtio-dev] [PATCH 2/2] virtio-gpu/2d: add docs/specs/
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [virtio-dev] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt |
Date: |
Mon, 15 Sep 2014 12:14:45 +0200 |
On Sa, 2014-09-13 at 07:14 +1000, Dave Airlie wrote:
> >> Can the host refuse due to lack of resources?
> >
> > Yes. virtgpu_ctrl_hdr.type in the response will be set to
> > VIRTGPU_RESP_ERR_* then. Current implementation does that only on
> > malloc() failure, there is no accounting (yet) to limit the amout of
> > memory the guest is allowed to allocate.
>
> We do probably need to work out some sort of accounting system, it can
> probably reliably only be a total value of resources, since we've no
> idea if the host driver will store them in VRAM or main memory. Quite
> how to fail gracefully is a question, probably need to report to the
> guest what context did the allocation and see if we can destroy it.
Best would be if virgilrenderer.so just fails
virgl_renderer_resource_create() calls.
> Not reason I can remember, I think I was thinking of having separate
> inval and detach at one point, but it didn't really make any sense, so
> renaming to detach is fine with me.
Done.
cheers,
Gerd
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, (continued)
[Qemu-devel] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt, Gerd Hoffmann, 2014/09/11
Re: [Qemu-devel] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt, Michael S. Tsirkin, 2014/09/14
Re: [Qemu-devel] [virtio-dev] [PATCH 0/2] virtio-gpu: hardware specification, Dave Airlie, 2014/09/12