Re: [Qemu-devel] [PATCH] configure: check for pixman-1 version

[Hu Tao]

CCed Paolo

On Mon, Sep 15, 2014 at 10:41:09AM +0800, Hu Tao wrote:
> On Sun, Sep 14, 2014 at 07:23:20PM -0700, Peter Maydell wrote:
> > On 14 September 2014 18:53, Hu Tao <address@hidden> wrote:
> > > commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only 
> > > available
> > > in pixman >= 0.21.8. If pixman doesn't meet the version requirement, qemu
> > > will fail to build with following message:
> > >
> > > /home/hutao/qemu/ui/qemu-pixman.c: In function 
> > > ‘qemu_pixelformat_from_pixman’:
> > > /home/hutao/qemu/ui/qemu-pixman.c:42: error: ‘PIXMAN_TYPE_RGBA’ 
> > > undeclared (first use in this function)
> > > /home/hutao/qemu/ui/qemu-pixman.c:42: error: (Each undeclared identifier 
> > > is reported only once
> > > /home/hutao/qemu/ui/qemu-pixman.c:42: error: for each function it appears 
> > > in.)
> > >
> > > This patch fixes the problem by checking the pixman version.
> > 
> > This alone is not sufficient, because the version of pixman
> > we have in our submodule is only 0.18.4. We also need to
> > bump that if we want to use newer versions (and to note
> > the increased dependency in our release notes next time
> > round).
> 
> Oh. I didn't noticed that. Should we just bump to the latest stable
> pixman? or choose a best version?

commit f27b2e1d bumped to pixman-0.28.2, but reverted later by 7b1b5d19 
(mistakenly?)

Regards,
Hu