[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] ui causes latest master build failure on rhel6
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] ui causes latest master build failure on rhel6 |
Date: |
Thu, 11 Sep 2014 21:17:04 +0300 |
On Thu, Sep 11, 2014 at 05:21:13PM +0200, Gerd Hoffmann wrote:
> On Do, 2014-09-11 at 17:59 +0300, Michael S. Tsirkin wrote:
> > I observe two errors with latest master:
> >
> > ui/qemu-pixman.c: In function ‘qemu_pixelformat_from_pixman’:
> > ui/qemu-pixman.c:42: error: ‘PIXMAN_TYPE_RGBA’ undeclared (first use in
> > this function)
> > ui/qemu-pixman.c:42: error: (Each undeclared identifier is reported only
> > once
> > ui/qemu-pixman.c:42: error: for each function it appears in.)
> > make: *** [ui/qemu-pixman.o] Error 1
>
> Guess we need to raise the minimum pixman version in configure ...
>
> pixman-0.21.8 is the oldest release which has PIXMAN_TYPE_RGBA.
> We don't check for a minimum version.
> RHEL-6 is probably older.
>
> Try 'configure --without-system-pixman' as workaround (after checking
> out the pixman submodule).
I guess but is it a must?
We used to have this within an ifdef:
+#if PIXMAN_VERSION >= PIXMAN_VERSION_ENCODE(0, 21, 8)
+ type = PIXMAN_TYPE_RGBA;
+#endif
+ }
can't we keep system pixman working a bit longer?
> I'll cook up a patch,
> Gerd
>