[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v3 16/18] spapr_pci_vfio: Enable DDW
|
From: |
Alexander Graf |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH v3 16/18] spapr_pci_vfio: Enable DDW |
|
Date: |
Wed, 10 Sep 2014 23:17:52 +0200 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 |
On 10.09.14 17:00, Alexey Kardashevskiy wrote:
> On 09/10/2014 11:03 PM, Alexander Graf wrote:
>>
>>
>> On 29.08.14 12:12, Alexey Kardashevskiy wrote:
>>> This implements DDW for VFIO. Host kernel support is required for this.
>>>
>>> After this patch DDW will be enabled on all machines but pseries-2.1.
>>
>> I fail to see the code that restricts DDW to pseries-2.1. Can you please
>> point me to it?
>
> Patch "[RFC PATCH v3 13/18] spapr_pci: Enable DDW" which enables DDW on
> spapr-pci disables it for the current machine by default.
>
> Since spapr-pci-vfio inherits from spapr-pci, this property is off for
> pseries-2.1 as well (I checked).
Ah, I see. The logic is still reversed. Old machine types get compat
options, new machine types don't. So the default should be "ddw enabled"
and pseries-2.1 gets a compat field saying "disable ddw".
Alex