|
| From: | Alexander Graf |
| Subject: | Re: [Qemu-devel] [PATCH v3 1/6] hw/misc/dyn_sysbus_binding: helpers for sysbus device dynamic binding |
| Date: | Wed, 10 Sep 2014 11:31:13 +0200 |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 |
On 09.09.14 17:59, Paolo Bonzini wrote: > Il 09/09/2014 17:25, Eric Auger ha scritto: >>>> >>>> Please provide a wrapper like sysbus_register_dynamic that takes the >>>> params/address_space_mem/mpic as parameter. platform_bus_init_notify >>>> and DynSysbusNotifier can remain hidden within the .c file. >> Sorry I do not catch what you mean here. platform_bus_init_notify & >> DynSysbusNotifier are currently used in virt.c to initialize & register >> the machine_init_done_notifier. > > Yeah, please do the registration in sysbus.c, not in virt.c. There is > no reason to make the platform_bus_init_notify+DynSysbusNotifier > interface public. The code in sysbus.c can fill in the fields. Sysbus != Platform bus. Sysbus is an in-QEMU representation of a pseudo-bus that we put all devices onto that we consider unsorted. Platform bus is a machine representation of an actual bus that devices are attached to. These devices usually are sysbus devices. Alex
| [Prev in Thread] | Current Thread | [Next in Thread] |