qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC v1 4/6] target_arm: Update armv7_init to support m


From: Martin Galvan
Subject: Re: [Qemu-devel] [RFC v1 4/6] target_arm: Update armv7_init to support more parameters
Date: Tue, 9 Sep 2014 11:03:07 -0300

>> @@ -259,7 +272,13 @@ qemu_irq *armv7m_init(MemoryRegion *system_memory,
>>      vmstate_register_ram_global(hack);
>>      memory_region_add_subregion(system_memory, 0xfffff000, hack);
>>
>> -    qemu_register_reset(armv7m_reset, cpu);
>> +    reset_args = (ARMV7MResetArgs) {
>> +        .cpu = cpu,
>> +        .reset_pc = entry,
>> +        .reset_sp = (0x20000000 + ((192 * 1024) * 2)/3),
>
> Why is the manual sp setting needed? I thought the V7M specific CPU
> reset code handled this? Does Martins ARMv7M ROM reset patch help by
> any chance?
>
> Regards,
> Peter

Indeed, I don't think that would be necessary with my patch. What are
those hardcoded magic numbers?

-- 


Martín Galván

Software Engineer

Taller Technologies Argentina


San Lorenzo 47, 3rd Floor, Office 5

Córdoba, Argentina

Phone: 54 351 4217888 / +54 351 4218211



reply via email to

[Prev in Thread] Current Thread [Next in Thread]