[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/10] pcspk: adding vmstate for save/restore
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 04/10] pcspk: adding vmstate for save/restore |
Date: |
Tue, 09 Sep 2014 15:28:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 09/09/2014 15:26, Juan Quintela ha scritto:
> Paolo Bonzini <address@hidden> wrote:
>> From: Pavel Dovgalyuk <address@hidden>
>>
>> VMState added by this patch preserves correct
>> loading of the PC speaker device state.
>>
>> This breaks migration to 2.1 and earlier.
>>
>> Signed-off-by: Pavel Dovgalyuk <address@hidden>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>
> This should only be added for new machine types, right?
We never did that in the past. Maybe downstream.
Paolo
> Later, Juan.
>
>> @@ -192,6 +203,7 @@ static void pcspk_class_initfn(ObjectClass *klass, void
>> *data)
>>
>> dc->realize = pcspk_realizefn;
>> set_bit(DEVICE_CATEGORY_SOUND, dc->categories);
>> + dc->vmsd = &vmstate_spk;
>> dc->props = pcspk_properties;
>> /* Reason: pointer property "pit", realize sets global pcspk_state */
>> dc->cannot_instantiate_with_device_add_yet = true;
- Re: [Qemu-devel] [PATCH 02/10] apic_common: vapic_paddr synchronization fix, (continued)
[Qemu-devel] [PATCH 06/10] parallel: adding vmstate for save/restore, Paolo Bonzini, 2014/09/09
[Qemu-devel] [PATCH 05/10] fdc: adding vmstate for save/restore, Paolo Bonzini, 2014/09/09