[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 22/24] vmdk: fix buf leak in vmdk_parse_extents()
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 22/24] vmdk: fix buf leak in vmdk_parse_extents() |
Date: |
Mon, 8 Sep 2014 11:51:47 +0100 |
vmdk_open_sparse() does not take ownership of buf so the caller always
needs to free it.
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
---
block/vmdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 9bf28f3..a1cb911 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -846,8 +846,8 @@ static int vmdk_parse_extents(const char *desc,
BlockDriverState *bs,
} else {
ret = vmdk_open_sparse(bs, extent_file, bs->open_flags, buf,
errp);
}
+ g_free(buf);
if (ret) {
- g_free(buf);
bdrv_unref(extent_file);
return ret;
}
--
1.9.3
- [Qemu-devel] [PULL 11/24] qemu-img: clarify src_cache option documentation, (continued)
- [Qemu-devel] [PULL 11/24] qemu-img: clarify src_cache option documentation, Stefan Hajnoczi, 2014/09/08
- [Qemu-devel] [PULL 17/24] MAINTAINERS: update sheepdog maintainer, Stefan Hajnoczi, 2014/09/08
- [Qemu-devel] [PULL 16/24] qemu-nbd: fix indentation and coding style, Stefan Hajnoczi, 2014/09/08
- [Qemu-devel] [PULL 13/24] block/archipelago: Use QEMU atomic builtins, Stefan Hajnoczi, 2014/09/08
- [Qemu-devel] [PULL 15/24] qemu-nbd: add option to set detect-zeroes mode, Stefan Hajnoczi, 2014/09/08
- [Qemu-devel] [PULL 18/24] libqos: add a simple first-fit memory allocator, Stefan Hajnoczi, 2014/09/08
- [Qemu-devel] [PULL 14/24] rename parse_enum_option to qapi_enum_parse and make it public, Stefan Hajnoczi, 2014/09/08
- [Qemu-devel] [PULL 19/24] qtest/ide: Uninitialize PC allocator, Stefan Hajnoczi, 2014/09/08
- [Qemu-devel] [PULL 20/24] ide: Add wwn support to IDE-ATAPI drive, Stefan Hajnoczi, 2014/09/08
- [Qemu-devel] [PULL 21/24] vmdk: fix vmdk_parse_extents() extent_file leaks, Stefan Hajnoczi, 2014/09/08
- [Qemu-devel] [PULL 22/24] vmdk: fix buf leak in vmdk_parse_extents(),
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 23/24] IDE: Fill the IDENTIFY request consistently, Stefan Hajnoczi, 2014/09/08
- [Qemu-devel] [PULL 24/24] ide: Add resize callback to ide/core, Stefan Hajnoczi, 2014/09/08
- Re: [Qemu-devel] [PULL v2 00/24] Block patches, Peter Maydell, 2014/09/08