[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] trace: Only link generated-tracers.o with "
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/3] trace: Only link generated-tracers.o with "simple" backend |
|
Date: |
Fri, 5 Sep 2014 10:04:30 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Sep 03, 2014 at 11:44:54AM +0800, Fam Zheng wrote:
> In any other cases the object file is effectively empty, which is
> disliked by ranlib and nm on Mac OS X.
>
> Reported-by: Peter Maydell <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> trace/Makefile.objs | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
If another trace backend uses generate_c() there will be a link error so
they'll figure out they need to add it in the makefile.
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgp0mCYlwgf_3.pgp
Description: PGP signature
- [Qemu-devel] [PATCH 0/3] build-sys: Exclude empty object files when linking libqemuutil.a, Fam Zheng, 2014/09/02
- [Qemu-devel] [PATCH 2/3] util: Move general qemu_getauxval to util/getauxval.c, Fam Zheng, 2014/09/02
- [Qemu-devel] [PATCH 1/3] trace: Only link generated-tracers.o with "simple" backend, Fam Zheng, 2014/09/02
- Re: [Qemu-devel] [PATCH 1/3] trace: Only link generated-tracers.o with "simple" backend,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 3/3] util: Don't link host-utils.o if it's empty, Fam Zheng, 2014/09/02
- Re: [Qemu-devel] [PATCH 0/3] build-sys: Exclude empty object files when linking libqemuutil.a, Paolo Bonzini, 2014/09/03
- Re: [Qemu-devel] [PATCH 0/3] build-sys: Exclude empty object files when linking libqemuutil.a, Peter Maydell, 2014/09/03