Re: [Qemu-devel] [PATCH v6 06/27] bootindex: move setting bootindex on reset() instead of realize/init()

[Eduardo Habkost]

On Sat, Aug 30, 2014 at 06:00:06PM +0800, address@hidden wrote:
> From: Gonglei <address@hidden>
> 
> Only in this way, we can assure the new bootindex take effect
> during vm rebooting.
> 
> Signed-off-by: Gonglei <address@hidden>

An API that doesn't work unless it is called at a very specific moment
(during reset) is very easy to misuse.

Why not simply make the core bootindex/reset code smart enough to update
the tables on reset if add_boot_device_path() was called at any moment,
instead of requiring all devices to call add_boot_device_path() on
reset?

-- 
Eduardo