[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] net: invoke callback when purging queue
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] net: invoke callback when purging queue |
Date: |
Thu, 4 Sep 2014 14:38:33 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Sep 04, 2014 at 11:39:10AM +0300, Michael S. Tsirkin wrote:
> devices rely on packet callbacks eventually running,
> but we violate this rule whenever we purge the queue.
> To fix, invoke callbacks on all packets on purge.
> Set length to 0, this way callers can detect that
> this happened and re-queue if necessary.
>
> Cc: address@hidden
> Cc: Jason Wang <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> net/queue.c | 3 +++
> 1 file changed, 3 insertions(+)
Merged "virtio: don't call device on !vm_running" before this to prevent
the assertion failures that Jason mentioned.
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
pgp8_7ot7D5oi.pgp
Description: PGP signature