Re: [Qemu-devel] [PATCH 03/17] ppc: fix monitor access to CR

[Tom Musta]

On 8/28/2014 12:14 PM, Paolo Bonzini wrote:
> This was off-by-one.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  monitor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/monitor.c b/monitor.c
> index 34cee74..ec73dd4 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2968,7 +2968,7 @@ static target_long monitor_get_ccr (const struct 
> MonitorDef *md, int val)
>  
>      u = 0;
>      for (i = 0; i < 8; i++)
> -        u |= env->crf[i] << (32 - (4 * i));
> +        u |= env->crf[i] << (32 - (4 * (i + 1)));
>  
>      return u;
>  }
> 

Reviewed-by: Tom Musta <address@hidden>