[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/5] s390x/gdb: various fixes
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH 0/5] s390x/gdb: various fixes |
Date: |
Tue, 02 Sep 2014 00:43:02 +0200 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
On 01.09.14 12:06, Christian Borntraeger wrote:
> On 29/08/14 15:52, Jens Freimann wrote:
>> Conny, Alex, Christian,
>>
>> here are some patches improving our gdb support.
>>
>> * Patch 1 fixes a bug where the cc was changed accidentally.
>> * Patch 2 adds the gdb feature XML files for s390x
>> * Patch 3 Define acr and fpr registers as coprocessor registers. This allows
>> us
>> to reuse the feature XML files.
>> * Patch 4 whitespace fixes
>> * Patch 5 changes common code and other architectures with gdb target.xml
>> support.
>> It adds a field gdb_arch_name to the XML description of the CPU and to
>> struct
>> CPUClass. It allows the remote gdb to detect the target architecture
>> in cases where it can't tell otherwise.
>>
>> David Hildenbrand (5):
>> s390x/gdb: don't touch the cc if tcg is not enabled
>> s390x/gdb: add the feature xml files for s390x
>> s390x/gdb: generate target.xml and handle fp/ac as coprocessors
>> s390x/gdb: coding style fixes
>> gdb: provide the name of the architecture in the target.xml
>>
>> configure | 1 +
>> gdb-xml/s390-acr.xml | 26 +++++++++++
>> gdb-xml/s390-fpr.xml | 27 +++++++++++
>> gdb-xml/s390x-core64.xml | 28 ++++++++++++
>> gdbstub.c | 19 +++++---
>> include/qom/cpu.h | 2 +
>> target-arm/cpu64.c | 1 +
>> target-ppc/translate_init.c | 2 +
>> target-s390x/cpu-qom.h | 1 +
>> target-s390x/cpu.c | 5 +-
>> target-s390x/cpu.h | 40 +---------------
>> target-s390x/gdbstub.c | 109
>> +++++++++++++++++++++++++++++++++-----------
>> 12 files changed, 188 insertions(+), 73 deletions(-)
>> create mode 100644 gdb-xml/s390-acr.xml
>> create mode 100644 gdb-xml/s390-fpr.xml
>> create mode 100644 gdb-xml/s390x-core64.xml
>>
>
> Applied 1-4.
>
> Peter,
> do you want to push patch5 yourself?
> As an alternative I can push it via the s390 tree, I need your ACK in that
> case.
>
> Alex, (or Alexey?) can you ACK/NACK patch 5 from the power perspective?
The ppc side looks reasonable I think. But I guess Richard is the person
to really ask here - FWIW he should know his way around gdb the best.
Alex