[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/12] pcspk: adding vmstate for save/restore
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 02/12] pcspk: adding vmstate for save/restore |
Date: |
Tue, 26 Aug 2014 11:10:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
Il 26/08/2014 09:14, Pavel Dovgalyuk ha scritto:
> VMState added by this patch preserves correct
> loading of the PC speaker device state.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> ---
> hw/audio/pcspk.c | 18 ++++++++++++++++--
> 1 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c
> index 1d81bbe..8b22dbf 100644
> --- a/hw/audio/pcspk.c
> +++ b/hw/audio/pcspk.c
> @@ -50,8 +50,8 @@ typedef struct {
> unsigned int pit_count;
> unsigned int samples;
> unsigned int play_pos;
> - int data_on;
> - int dummy_refresh_clock;
> + uint8_t data_on;
> + uint8_t dummy_refresh_clock;
> } PCSpkState;
>
> static const char *s_spk = "pcspk";
> @@ -163,6 +163,18 @@ static const MemoryRegionOps pcspk_io_ops = {
> },
> };
>
> +static const VMStateDescription vmstate_spk = {
> + .name = "pcspk",
> + .version_id = 1,
> + .minimum_version_id = 1,
> + .minimum_version_id_old = 1,
> + .fields = (VMStateField[]) {
> + VMSTATE_UINT8(data_on, PCSpkState),
> + VMSTATE_UINT8(dummy_refresh_clock, PCSpkState),
> + VMSTATE_END_OF_LIST()
> + }
> +};
> +
> static void pcspk_initfn(Object *obj)
> {
> PCSpkState *s = PC_SPEAKER(obj);
> @@ -175,6 +187,8 @@ static void pcspk_realizefn(DeviceState *dev, Error
> **errp)
> ISADevice *isadev = ISA_DEVICE(dev);
> PCSpkState *s = PC_SPEAKER(dev);
>
> + vmstate_register(NULL, 0, &vmstate_spk, s);
> +
> isa_register_ioport(isadev, &s->ioport, s->iobase);
>
> pcspk_state = s;
>
>
>
I think you should use dc->vmsd.
Paolo
- [Qemu-devel] [PATCH 00/12] Fixing hardware migration issues, Pavel Dovgalyuk, 2014/08/26
- [Qemu-devel] [PATCH 01/12] integratorcp: adding vmstate for save/restore, Pavel Dovgalyuk, 2014/08/26
- [Qemu-devel] [PATCH 02/12] pcspk: adding vmstate for save/restore, Pavel Dovgalyuk, 2014/08/26
- Re: [Qemu-devel] [PATCH 02/12] pcspk: adding vmstate for save/restore,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 03/12] fdc: adding vmstate for save/restore, Pavel Dovgalyuk, 2014/08/26
- [Qemu-devel] [PATCH 04/12] parallel: adding vmstate for save/restore, Pavel Dovgalyuk, 2014/08/26
- [Qemu-devel] [PATCH 05/12] serial: fixing vmstate for save/restore, Pavel Dovgalyuk, 2014/08/26
- [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate, Pavel Dovgalyuk, 2014/08/26