[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [V2 PATCH 02/12] linux-user: Dereference Pointer Argume
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [V2 PATCH 02/12] linux-user: Dereference Pointer Argument to ipc/semctl Sys Call |
Date: |
Tue, 26 Aug 2014 10:32:18 +1000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Aug 12, 2014 at 01:53:33PM -0500, Tom Musta wrote:
> When the ipc system call is used to wrap a semctl system call,
> the ptr argument to ipc needs to be dereferenced prior to passing
> it to the semctl handler. This is because the fourth argument to
> semctl is a union and not a pointer to a union.
>
> Signed-off-by: Tom Musta <address@hidden>
> ---
>
> V2: This is unchanged from V1. I briefly reviewew the QEMU, glibc and
> kernel code
> looking for some problems but did not find anything. I also did fairly
> comprehesive
> testing of semctl on 4 targets (ppc-linux-user, ppc64-linux-user,
> ppc64le-linux-user,
> x86_64-linux-user) on 3 different host platforms (x86-64 Ubuntu, PPC64 RHEL 6
> (BE) and
> PPC64 Ubuntu 14.04 (LE)); this provided a broad coverage of co-endian and
> cross endian
> situations.
Reviewed-by: David Gibson <address@hidden>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpj3J19YoPxp.pgp
Description: PGP signature
- [Qemu-devel] [V2 PATCH 00/12] target-ppc: Linux-User Mode Bug Fixes for Power, Tom Musta, 2014/08/12
- [Qemu-devel] [V2 PATCH 01/12] linux-user: PPC64 semid_ds Doesnt Include _unused1 and _unused2, Tom Musta, 2014/08/12
- [Qemu-devel] [V2 PATCH 02/12] linux-user: Dereference Pointer Argument to ipc/semctl Sys Call, Tom Musta, 2014/08/12
- Re: [Qemu-devel] [V2 PATCH 02/12] linux-user: Dereference Pointer Argument to ipc/semctl Sys Call,
David Gibson <=
- [Qemu-devel] [V2 PATCH 03/12] linux-user: Properly Handle semun Structure In Cross-Endian Situations, Tom Musta, 2014/08/12
- [Qemu-devel] [V2 PATCH 04/12] linux-user: Make ipc syscall's third argument an abi_long, Tom Musta, 2014/08/12
- [Qemu-devel] [V2 PATCH 05/12] linux-user: Conditionally Pass Attribute Pointer to mq_open(), Tom Musta, 2014/08/12
- [Qemu-devel] [V2 PATCH 06/12] linux-user: Detect Negative Message Sizes in msgsnd System Call, Tom Musta, 2014/08/12
- [Qemu-devel] [V2 PATCH 08/12] linux-user: Detect fault in sched_rr_get_interval, Tom Musta, 2014/08/12