[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] usb: Fix bootindex for portnr > 9
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] usb: Fix bootindex for portnr > 9 |
Date: |
Mon, 25 Aug 2014 16:33:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Gerd Hoffmann <address@hidden> writes:
> On Fr, 2014-08-15 at 13:32 +0200, Markus Armbruster wrote:
>> We identify devices by their Open Firmware device paths. The encoding
>> of the host controller and hub port numbers is incorrect:
>> usb_get_fw_dev_path() formats them in decimal, while SeaBIOS uses
>> hexadecimal. When some port number > 9, SeaBIOS will miss the
>> bootindex (lucky case), or apply it to another device (unlucky case).
>>
>> The relevant spec[*] agrees with SeaBIOS (and OVMF, for that matter).
>> Change %d to %x.
>>
>> Bug can bite only with host controllers or hubs sporting more than ten
>> ports. I'm not aware of any.
>
> fyi: xhci can be configured with up to 15 ports (default is 4 ports
> though).
Would be nice to put that into the commit message, between my S-o-B and
yours.
> Applied to usb patch queue.
Thanks!