[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little e
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian |
Date: |
Fri, 22 Aug 2014 10:22:01 +0100 |
You forgot to cc qemu-devel...
On 22 August 2014 09:52, Valentin Manea <address@hidden> wrote:
> Set the IDE MMIO memory type to little endian. The ATA specs identify
> words part of the control commands encoded as little endian.
> While this has no impact on little endian systems, it's required for big
> endian systems(eg OpenRisc).
>
> Signed-off-by: Valentin Manea <address@hidden>
> ---
> hw/ide/mmio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ide/mmio.c b/hw/ide/mmio.c
> index 01c1d0e..334c8cc 100644
> --- a/hw/ide/mmio.c
> +++ b/hw/ide/mmio.c
> @@ -82,7 +82,7 @@ static void mmio_ide_write(void *opaque, hwaddr addr,
> static const MemoryRegionOps mmio_ide_ops = {
> .read = mmio_ide_read,
> .write = mmio_ide_write,
> - .endianness = DEVICE_NATIVE_ENDIAN,
> + .endianness = DEVICE_LITTLE_ENDIAN,
> };
>
> static uint64_t mmio_ide_status_read(void *opaque, hwaddr addr,
> @@ -102,7 +102,7 @@ static void mmio_ide_cmd_write(void *opaque, hwaddr
> addr,
> static const MemoryRegionOps mmio_ide_cs_ops = {
> .read = mmio_ide_status_read,
> .write = mmio_ide_cmd_write,
> - .endianness = DEVICE_NATIVE_ENDIAN,
> + .endianness = DEVICE_LITTLE_ENDIAN,
> };
>
> static const VMStateDescription vmstate_ide_mmio = {
> --
> 1.9.1
thanks
-- PMM
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian,
Peter Maydell <=