[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scsi-generic: fix debug print compiling error
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] scsi-generic: fix debug print compiling error |
Date: |
Thu, 21 Aug 2014 15:39:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
Il 21/08/2014 14:19, address@hidden ha scritto:
> From: Gonglei <address@hidden>
>
> variables lun and tag had been eliminated, broke compiling
> when enable debug switch.
>
> Signed-off-by: Gonglei <address@hidden>
> ---
> hw/scsi/scsi-generic.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c
> index 0b2ff90..3808694 100644
> --- a/hw/scsi/scsi-generic.c
> +++ b/hw/scsi/scsi-generic.c
> @@ -303,8 +303,7 @@ static int32_t scsi_send_command(SCSIRequest *req,
> uint8_t *cmd)
> SCSIDevice *s = r->req.dev;
> int ret;
>
> - DPRINTF("Command: lun=%d tag=0x%x len %zd data=0x%02x", lun, tag,
> - r->req.cmd.xfer, cmd[0]);
> + DPRINTF("Command: len %zd data=0x%02x\n", r->req.cmd.xfer, cmd[0]);
You can use r->req.tag (but traces provide the same information really,
so I'd also accept a patch to remove superfluous DPRINTFs that keep
breaking).
Paolo
> #ifdef DEBUG_SCSI
> {
>