Re: [Qemu-devel] [PATCH 1/3] qdev: add missing error check

[Gonglei (Arei)]

> -----Original Message-----
> From: Paolo Bonzini [mailto:address@hidden
> Sent: Tuesday, August 19, 2014 10:03 PM
> To: Peter Crosthwaite; Gonglei (Arei)
> Cc: address@hidden Developers; Huangweidong (C); Michael S. Tsirkin;
> Huangpeng (Peter); Igor Mammedov; Andreas Färber
> Subject: Re: [Qemu-devel] [PATCH 1/3] qdev: add missing error check
> 
> Il 19/08/2014 15:50, Peter Crosthwaite ha scritto:
> > So I'm curious to know if and how this manifested for you as a bug?
> > Can you reproduce this as a bug somehow even as a memory leak? as the
> > only way I can see local_err getting populated is a fail of:
> >
> >
> object_property_add_child(container_get(qdev_get_machine(),
> >
> "/unattached"),
> >                                       name, obj, &local_err);
> >
> > Which, if fails indicates something very wrong. Should we promote that
> > fail to &error_abort and just drop the local_err logic entirely? I'm
> > very interested on your replication conditions on this one.
> 
> Yes, I don't think it can happen.  The user can only refer to
> /machine/peripheral, not /machine/unattached.  &error_abort is better.
> 
Yes. I agree, will do. 
Thanks, Paolo.

Best regards,
-Gonglei