qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] qcow2: Use g_try_new0() for cache array


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH 2/4] qcow2: Use g_try_new0() for cache array
Date: Mon, 18 Aug 2014 22:01:54 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0

On 18.08.2014 22:00, Max Reitz wrote:
With a variable cache size, the number given to qcow2_cache_create() may
be huge. Therefore, use g_try_new0().

While at it, use g_new0() instead of g_malloc0() for allocating the
Qcow2Cache object.

Signed-off-by: Max Reitz <address@hidden>
---
  block/qcow2-cache.c | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c
index fe0615a..6eabfaa 100644
--- a/block/qcow2-cache.c
+++ b/block/qcow2-cache.c
@@ -48,9 +48,12 @@ Qcow2Cache *qcow2_cache_create(BlockDriverState *bs, int 
num_tables)
      Qcow2Cache *c;
      int i;
- c = g_malloc0(sizeof(*c));
+    c = g_new0(Qcow2Cache, 1);
      c->size = num_tables;
-    c->entries = g_new0(Qcow2CachedTable, num_tables);
+    c->entries = g_try_new0(Qcow2CachedTable, num_tables);
+    if (!c->entries) {
+        goto fail;
+    }

Self-NACK: The fail path needs to acknowledge that c->entries may be NULL.

Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]