[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] pc-dimm: Change PCDIMMDevice->node from UIN
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1. |
|
Date: |
Mon, 18 Aug 2014 15:58:33 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
Il 18/08/2014 15:56, Michael S. Tsirkin ha scritto:
> > +/* Initialize PCDIMMDevice->node to -1 so that even if user doesn't specify
> > + * any numa option, PCDIMMDevice->node won't be 0, which indicates node0.
> > + * In this case, SRAT won't be created, and guest kernel will fake a node.
> > + */
>
> I think you simply mean
> /* default value for PCDIMMDevice->node (unless specified by user) */
>
> > +#define NO_NODE_ID -1
I think a comment about the SRAT would be useful.
Paolo