[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 05/12] pc-dimm: validate node property
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 05/12] pc-dimm: validate node property |
Date: |
Thu, 14 Aug 2014 18:08:57 +0200 |
From: Hu Tao <address@hidden>
If user specifies a node number that exceeds the available numa nodes in
emulated system for pc-dimm device, the device will report an invalid _PXM
to OSPM. Fix this by checking the node property value.
Cc: address@hidden
Signed-off-by: Hu Tao <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/mem/pc-dimm.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index 08f49ed..92e276f 100644
--- a/hw/mem/pc-dimm.c
+++ b/hw/mem/pc-dimm.c
@@ -252,6 +252,11 @@ static void pc_dimm_realize(DeviceState *dev, Error **errp)
error_setg(errp, "'" PC_DIMM_MEMDEV_PROP "' property is not set");
return;
}
+ if (dimm->node >= nb_numa_nodes) {
+ error_setg(errp, "'" PC_DIMM_NODE_PROP
+ "' exceeds numa node number: %" PRId32, nb_numa_nodes);
+ return;
+ }
}
static MemoryRegion *pc_dimm_get_memory_region(PCDIMMDevice *dimm)
--
MST
- [Qemu-devel] [PULL 00/12] post-2.1 bugfixes, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 02/12] pc: Create 2.2 machine type, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 01/12] pci: Use bus master address space for delivering MSI/MSI-X messages, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 04/12] hw:i386: typo fix: MEMORY_HOPTLUG_DEVICE -> MEMORY_HOTPLUG_DEVICE, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 05/12] pc-dimm: validate node property,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 06/12] pc-dimm: fix up error message, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 07/12] numa: show hex number in error message for consistency and prefix them with 0x, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 08/12] acpi: align RSDP, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 09/12] ivshmem: fix building when debug mode is enabled, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 03/12] hw/audio/intel-hda: Fix MSI capability address, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 10/12] e1000: correctly handle phy_ctrl reserved & self-clearing bits, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 11/12] e1000: use symbolic constants to init phy ctrl & status registers, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 12/12] pc: Get rid of pci-info leftovers, Michael S. Tsirkin, 2014/08/14