[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 07/14] qapi: add some type check tests
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 07/14] qapi: add some type check tests |
Date: |
Thu, 14 Aug 2014 06:26:50 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 08/14/2014 03:47 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> Demonstrate that the qapi generator silently parses confusing
>> types, which may cause other errors later on. Later patches
>> will update the expected results as the generator is made stricter.
>>
>> * tests/qapi-schema/data-array-empty.*: New files.
>> * tests/qapi-schema/data-array-unknown.*: Likewise.
>> * tests/qapi-schema/data-unknown.*: Likewise.
>> * tests/qapi-schema/data-int.*: Likewise.
>> * tests/qapi-schema/returns-unknown.*: Likewise.
>> * tests/qapi-schema/returns-int.*: Likewise.
>> * tests/qapi-schema/returns-array-bad.*: Likewise.
>> * tests/Makefile (check-qapi-schema-y): Run them.
>>
>> +++ b/tests/qapi-schema/returns-array-bad.json
>> @@ -0,0 +1 @@
>> +{ 'command': 'oops', 'data': [ 'str', 'str' ] }
>
> The file name suggests you want to test 'returns' rather than 'data' here.
D'oh. Definite reason to respin the series.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 01/14] qapi: consistent whitespace in tests/Makefile, (continued)
- [Qemu-devel] [PATCH v3 05/14] qapi: add some expr tests, Eric Blake, 2014/08/05
- [Qemu-devel] [PATCH v3 02/14] qapi: ignore files created during make check, Eric Blake, 2014/08/05
- [Qemu-devel] [PATCH v3 14/14] qapi: drop support for inline subtypes, Eric Blake, 2014/08/05
- [Qemu-devel] [PATCH v3 07/14] qapi: add some type check tests, Eric Blake, 2014/08/05
- [Qemu-devel] [PATCH v3 13/14] qapi: drop inline subtype in query-pci, Eric Blake, 2014/08/05
- [Qemu-devel] [PATCH v3 10/14] qapi: merge UserDefTwo and UserDefNested in tests, Eric Blake, 2014/08/05
- [Qemu-devel] [PATCH v3 12/14] qapi: drop inline subtype in query-version, Eric Blake, 2014/08/05
- [Qemu-devel] [PATCH v3 11/14] qapi: drop tests for inline subtypes, Eric Blake, 2014/08/05
- Re: [Qemu-devel] [PATCH v3 00/14] drop qapi nested structs, Eric Blake, 2014/08/12
- Re: [Qemu-devel] [PATCH v3 00/14] drop qapi nested structs, Markus Armbruster, 2014/08/14
- Re: [Qemu-devel] [PATCH v3 00/14] drop qapi nested structs, Luiz Capitulino, 2014/08/15