[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 03/16] qdev: gpio: Register GPIO outputs as Q
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH v1 03/16] qdev: gpio: Register GPIO outputs as QOM links |
Date: |
Thu, 14 Aug 2014 17:30:27 +1000 |
On Mon, Aug 4, 2014 at 11:53 AM, Peter Crosthwaite
<address@hidden> wrote:
> Within the object that contains the GPIO output. This allows for
> connecting GPIO outputs via setting of a Link property.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
>
> hw/core/qdev.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index 35c266a..5f55709 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -362,12 +362,23 @@ void qdev_init_gpio_in(DeviceState *dev,
> qemu_irq_handler handler, int n)
> void qdev_init_gpio_out_named(DeviceState *dev, qemu_irq *pins,
> const char *name, int n)
> {
> + int i;
> NamedGPIOList *gpio_list = qdev_get_named_gpio_list(dev, name);
>
> assert(gpio_list->num_in == 0 || !name);
> assert(gpio_list->num_out == 0);
> gpio_list->num_out = n;
> gpio_list->out = pins;
> +
> + char *propname = g_strdup_printf("%s[*]", name ? name :
> "unnamed-gpio-out");
Moved this up the function in V2. sry.
Regards,
Peter
> + for (i = 0; i < n; ++i) {
> + object_property_add_link(OBJECT(dev), propname, TYPE_IRQ,
> + (Object **)&pins[i],
> + object_property_allow_set_link,
> + OBJ_PROP_LINK_UNREF_ON_RELEASE,
> + &error_abort);
> + }
> + g_free(propname);
> }
>
> void qdev_init_gpio_out(DeviceState *dev, qemu_irq *pins, int n)
> --
> 2.0.1.1.gfbfc394
>
- [Qemu-devel] [PATCH v1 00/16] GPIO/IRQ QOMification: Phase 2 - Getting rid of SYSBUS IRQs, Peter Crosthwaite, 2014/08/03
- [Qemu-devel] [PATCH v1 01/16] qdev: gpio: Don't allow name share between I and O, Peter Crosthwaite, 2014/08/03
- [Qemu-devel] [PATCH v1 02/16] qdev: gpio: Register GPIO inputs as child objects, Peter Crosthwaite, 2014/08/03
- [Qemu-devel] [PATCH v1 03/16] qdev: gpio: Register GPIO outputs as QOM links, Peter Crosthwaite, 2014/08/03
- Re: [Qemu-devel] [PATCH v1 03/16] qdev: gpio: Register GPIO outputs as QOM links,
Peter Crosthwaite <=
- [Qemu-devel] [PATCH v1 04/16] qmp: qstring: Handle NULL strings, Peter Crosthwaite, 2014/08/03
- [Qemu-devel] [PATCH v1 05/16] qom: Allow clearing of a Link property, Peter Crosthwaite, 2014/08/03
- [Qemu-devel] [PATCH v1 06/16] qom: Demote already-has-a-parent to a regular error, Peter Crosthwaite, 2014/08/03
- [Qemu-devel] [PATCH v1 07/16] qdev: gpio: Re-impement qdev_connect_gpio QOM style, Peter Crosthwaite, 2014/08/03
- [Qemu-devel] [PATCH v1 08/16] qdev: gpio: Add API for intercepting an IRQ, Peter Crosthwaite, 2014/08/03
- [Qemu-devel] [PATCH v1 09/16] qtest/irq: Rework IRQ interception, Peter Crosthwaite, 2014/08/03
- [Qemu-devel] [PATCH v1 10/16] irq: Remove qemu_irq_intercept_out, Peter Crosthwaite, 2014/08/03
- [Qemu-devel] [PATCH v1 11/16] qdev: gpio: delete NamedGPIOList::out, Peter Crosthwaite, 2014/08/03