[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: add watermark event
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] block: add watermark event |
|
Date: |
Fri, 08 Aug 2014 06:51:34 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 08/08/2014 02:01 AM, Francesco Romani wrote:
>>>> So let the block-set-watermark caller pass an absolute sector number
>>>> instead. It keeps things simple for both QEMU and thin provisioning
>>>> manager.
>>>
>>> No sector numbers in external interfaces, please. These units of 512
>>> bytes are completely arbitrary and don't make any sense. I hope to get
>>> rid of BDRV_SECTOR_* eventually even internally.
>>>
>>> So for external APIs, please use bytes instead.
>>
>> I agree and forgot about that. Please use bytes instead of sectors or a
>> percentage.
>>
>
> Thanks everyone for the great feedback received!
>
> I'll post asap a new patch addressing all the comments.
>
> I'll also change the name because 'watermark' may be misleading/wrong jargon
> :)
> (http://en.wikipedia.org/wiki/Watermark)
Is "threshold" a better name than "watermark"?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature