qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [Bug 1353545] [NEW] QED does not deliver flush on synchroni


From: Nybble
Subject: [Qemu-devel] [Bug 1353545] [NEW] QED does not deliver flush on synchronized write
Date: Wed, 06 Aug 2014 14:57:22 -0000

Public bug reported:

At least one flush method should be provided by qed driver
(common/co/aio).

I was doing "sync write" benchmarking on varies qemu supported formats
(on ssd). I was surprised that QED shows significant high performance
over several other formats (qcow2/vmdk/vdi..). In some test cases QED
even runs a little bit faster than raw format!

After careful reading of the code I found QED skipped the necessary
flush by providing nothing on flush api. unlike read/write which require
at least one type of implementation, flush API is not mandatory because
your format could guarantee that synchronization is done in write path
or others. However that's not the case in QED because data is buffered
in the "bs->file" and QED needs to propagate the flush command to it to
make data safe.

However I'm not a skilled qemu developer. Above is what I got from my
thinking and study. Please correct me if in any way I misunderstood the
design. I really appreciate!

The patch is short:
https://github.com/wuxb45/qemu/commit/fe46e640f53a006907091e910fb4868a878ea0a8

qemu release version: 2.1.0. But this should have been there for a long time.
The patch is based on this recent commit:
69f87f713069f1f70f86cb65883f7d43e3aa21de

Thanks.

** Affects: qemu
     Importance: Undecided
         Status: New


** Tags: block disk qed

** Description changed:

  At least one flush method should be provided by qed driver
  (common/co/aio).
  
- 
- I was doing "sync write" benchmarking on varies qemu supported formats (on 
ssd). I was surprised that QED shows significant high performance over several 
other formats (qcow2/vmdk/vdi..). In some test cases QED even runs a little bit 
faster than raw format!
+ I was doing "sync write" benchmarking on varies qemu supported formats
+ (on ssd). I was surprised that QED shows significant high performance
+ over several other formats (qcow2/vmdk/vdi..). In some test cases QED
+ even runs a little bit faster than raw format!
  
  After careful reading of the code I found QED skipped the necessary
  flush by providing nothing on flush api. unlike read/write which require
  at least one type of implementation, flush API is not mandatory because
  your format could guarantee that synchronization is done in write path
  or others. However that's not the case in QED because data is buffered
- in the "bs->file" and it needs to populate the flush command to make
- data safe.
+ in the "bs->file" and QED needs to propagate the flush command to it to
+ make data safe.
  
  However I'm not a skilled qemu developer. Above is what I got from my
- thinking and study. Please correct me if I misunderstood the design. I
- really appreciate!
+ thinking and study. Please correct me if in any way I misunderstood the
+ design. I really appreciate!
  
- The patch is short: 
+ The patch is short:
  https://github.com/wuxb45/qemu/commit/fe46e640f53a006907091e910fb4868a878ea0a8
  
- qemu release version: 2.1.0. But this should have been their for a long time.
+ qemu release version: 2.1.0. But this should have been there for a long time.
  The patch is based on this recent commit:
  69f87f713069f1f70f86cb65883f7d43e3aa21de
  
- 
  Thanks.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1353545

Title:
  QED does not deliver flush on synchronized write

Status in QEMU:
  New

Bug description:
  At least one flush method should be provided by qed driver
  (common/co/aio).

  I was doing "sync write" benchmarking on varies qemu supported formats
  (on ssd). I was surprised that QED shows significant high performance
  over several other formats (qcow2/vmdk/vdi..). In some test cases QED
  even runs a little bit faster than raw format!

  After careful reading of the code I found QED skipped the necessary
  flush by providing nothing on flush api. unlike read/write which
  require at least one type of implementation, flush API is not
  mandatory because your format could guarantee that synchronization is
  done in write path or others. However that's not the case in QED
  because data is buffered in the "bs->file" and QED needs to propagate
  the flush command to it to make data safe.

  However I'm not a skilled qemu developer. Above is what I got from my
  thinking and study. Please correct me if in any way I misunderstood
  the design. I really appreciate!

  The patch is short:
  https://github.com/wuxb45/qemu/commit/fe46e640f53a006907091e910fb4868a878ea0a8

  qemu release version: 2.1.0. But this should have been there for a long time.
  The patch is based on this recent commit:
  69f87f713069f1f70f86cb65883f7d43e3aa21de

  Thanks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1353545/+subscriptions



reply via email to

[Prev in Thread] Current Thread [Next in Thread]