[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 5/6] hostmem-ram: don't exit qemu if size of
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH v5 5/6] hostmem-ram: don't exit qemu if size of memory-backend-ram is way too big |
Date: |
Wed, 6 Aug 2014 22:37:28 +1000 |
On Wed, Aug 6, 2014 at 3:36 PM, Hu Tao <address@hidden> wrote:
> When using monitor command object_add to add a memory backend whose
> size is way too big to allocate memory for it, qemu just exits. In
> the case we'd better give an error message and keep guest running.
>
> The problem can be reproduced as follows:
>
> 1. run qemu
> 2. (monitor)object_add memory-backend-ram,size=100000G,id=ram0
>
> Signed-off-by: Hu Tao <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
> ---
> backends/hostmem-ram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/backends/hostmem-ram.c b/backends/hostmem-ram.c
> index e55d066..a67a134 100644
> --- a/backends/hostmem-ram.c
> +++ b/backends/hostmem-ram.c
> @@ -27,7 +27,7 @@ ram_backend_memory_alloc(HostMemoryBackend *backend, Error
> **errp)
>
> path = object_get_canonical_path_component(OBJECT(backend));
> memory_region_init_ram(&backend->mr, OBJECT(backend), path,
> - backend->size, &error_abort);
> + backend->size, errp);
> g_free(path);
> }
>
> --
> 1.9.3
>
>
- Re: [Qemu-devel] [PATCH v5 1/6] exec: add parameter errp to qemu_ram_alloc and qemu_ram_alloc_from_ptr, (continued)
- [Qemu-devel] [PATCH v5 2/6] memory: add parameter errp to memory_region_init_ram, Hu Tao, 2014/08/06
- [Qemu-devel] [PATCH v5 3/6] memory: add parameter errp to memory_region_init_ram_ptr, Hu Tao, 2014/08/06
- [Qemu-devel] [PATCH v5 4/6] memory: add parameter errp to memory_region_init_rom_device, Hu Tao, 2014/08/06
- [Qemu-devel] [PATCH v5 5/6] hostmem-ram: don't exit qemu if size of memory-backend-ram is way too big, Hu Tao, 2014/08/06
- Re: [Qemu-devel] [PATCH v5 5/6] hostmem-ram: don't exit qemu if size of memory-backend-ram is way too big,
Peter Crosthwaite <=
- [Qemu-devel] [PATCH v5 6/6] exec: improve error handling and reporting in file_ram_alloc() and gethugepagesize(), Hu Tao, 2014/08/06