[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] acpi: align RSDP
|
From: |
Laszlo Ersek |
|
Subject: |
Re: [Qemu-devel] [PATCH] acpi: align RSDP |
|
Date: |
Tue, 05 Aug 2014 17:25:53 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 08/04/14 17:40, Michael S. Tsirkin wrote:
> RSDP should be aligned at a 16-byte boundary.
> This would by chance at the moment, fix up acpi build
> to make it robust.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/i386/acpi-build.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 816c6d9..10b84d0 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1393,7 +1393,7 @@ build_rsdp(GArray *rsdp_table, GArray *linker, unsigned
> rsdt)
> {
> AcpiRsdpDescriptor *rsdp = acpi_data_push(rsdp_table, sizeof *rsdp);
>
> - bios_linker_loader_alloc(linker, ACPI_BUILD_RSDP_FILE, 1,
> + bios_linker_loader_alloc(linker, ACPI_BUILD_RSDP_FILE, 16,
> true /* fseg memory */);
>
> memcpy(&rsdp->signature, "RSD PTR ", 8);
>
Reviewed-by: Laszlo Ersek <address@hidden>