Re: [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards

[Michael S. Tsirkin]

On Tue, Jul 22, 2014 at 09:28:55AM +0200, Gerd Hoffmann wrote:
> This way the tests run without sound hardware being present
> on the build machine.  Even with sound hardware it IMO isn't
> very useful to use it in regression testing.  Once the sound
> card tests are advanced enougth that they try to actually
> play sound we probably want the guests sound output written
> to a file (via QEMU_AUDIO_DRV=wav) rather than played on the
> build machines sound hardware.
> 
> Signed-off-by: Gerd Hoffmann <address@hidden>

Useful already:
Reviewed-by: Michael S. Tsirkin <address@hidden>

Long term, won't it be cleaner to supply driver using
a command line flag? Can be a patch on top ...

> ---
>  tests/ac97-test.c      | 3 +++
>  tests/es1370-test.c    | 3 +++
>  tests/intel-hda-test.c | 3 +++
>  3 files changed, 9 insertions(+)
> 
> diff --git a/tests/ac97-test.c b/tests/ac97-test.c
> index af30ea1..ba3be1a 100644
> --- a/tests/ac97-test.c
> +++ b/tests/ac97-test.c
> @@ -8,6 +8,7 @@
>   */
>  
>  #include <glib.h>
> +#include <stdlib.h>
>  #include <string.h>
>  #include "libqtest.h"
>  #include "qemu/osdep.h"
> @@ -21,6 +22,8 @@ int main(int argc, char **argv)
>  {
>      int ret;
>  
> +    setenv("QEMU_AUDIO_DRV", "none", true);
> +
>      g_test_init(&argc, &argv, NULL);
>      qtest_add_func("/ac97/nop", nop);
>  
> diff --git a/tests/es1370-test.c b/tests/es1370-test.c
> index cc23fb5..d539ba3 100644
> --- a/tests/es1370-test.c
> +++ b/tests/es1370-test.c
> @@ -8,6 +8,7 @@
>   */
>  
>  #include <glib.h>
> +#include <stdlib.h>
>  #include <string.h>
>  #include "libqtest.h"
>  #include "qemu/osdep.h"
> @@ -21,6 +22,8 @@ int main(int argc, char **argv)
>  {
>      int ret;
>  
> +    setenv("QEMU_AUDIO_DRV", "none", true);
> +
>      g_test_init(&argc, &argv, NULL);
>      qtest_add_func("/es1370/nop", nop);
>  
> diff --git a/tests/intel-hda-test.c b/tests/intel-hda-test.c
> index d89b407..32dc58f 100644
> --- a/tests/intel-hda-test.c
> +++ b/tests/intel-hda-test.c
> @@ -8,6 +8,7 @@
>   */
>  
>  #include <glib.h>
> +#include <stdlib.h>
>  #include <string.h>
>  #include "libqtest.h"
>  #include "qemu/osdep.h"
> @@ -35,6 +36,8 @@ int main(int argc, char **argv)
>  {
>      int ret;
>  
> +    setenv("QEMU_AUDIO_DRV", "none", true);
> +
>      g_test_init(&argc, &argv, NULL);
>      qtest_add_func("/intel-hda/ich6", ich6_test);
>      qtest_add_func("/intel-hda/ich9", ich9_test);
> -- 
> 1.8.3.1
>