[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/12] linux-user: writev Partial Writes
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 12/12] linux-user: writev Partial Writes |
Date: |
Mon, 4 Aug 2014 18:29:27 +0100 |
On 4 August 2014 17:45, Tom Musta <address@hidden> wrote:
> Although not technically not required by POSIX, the writev system call will
> typically write out its buffers individually. That is, if the first buffer
> is written successfully, but the second buffer pointer is invalid, then
> the first chuck will be written and its size is returned.
>
> Signed-off-by: Tom Musta <address@hidden>
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index fea54be..19e78dc 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -1798,6 +1798,7 @@ static struct iovec *lock_iovec(int type, abi_ulong
> target_addr,
> abi_ulong total_len, max_len;
> int i;
> int err = 0;
> + int bad_address = 0;
I would use a bool here rather than int. Other than that nit,
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH 09/12] linux-user: Minimum Sig Handler Stack Size for PPC64 ELF V2, (continued)
- [Qemu-devel] [PATCH 09/12] linux-user: Minimum Sig Handler Stack Size for PPC64 ELF V2, Tom Musta, 2014/08/04
- [Qemu-devel] [PATCH 10/12] linux-user: clock_nanosleep errno Handling on PPC, Tom Musta, 2014/08/04
- [Qemu-devel] [PATCH 11/12] linux-user: Support target-to-host translation of mlockall argument, Tom Musta, 2014/08/04
- [Qemu-devel] [PATCH 12/12] linux-user: writev Partial Writes, Tom Musta, 2014/08/04
- Re: [Qemu-devel] [PATCH 12/12] linux-user: writev Partial Writes,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 00/12] target-ppc: Linux-User Mode Bug Fixes for Power, Riku Voipio, 2014/08/12