Re: [Qemu-devel] [PATCH v2 5/7] qmp: add set-bootindex command

[Gonglei (Arei)]

Hi,

> Subject: Re: [Qemu-devel] [PATCH v2 5/7] qmp: add set-bootindex command
> 
> On Fri, Jul 25, 2014 at 02:52:50PM +0800, address@hidden wrote:
> > From: Gonglei <address@hidden>
> >
> > Adds "set-bootindex id=xx,bootindex=xx,suffix=xx" QMP command.
> >
> > Example QMP command:
> > -> { "execute": "set-bootindex", "arguments": { "id": "ide0-0-1", 
> > "bootindex":
> 1, "suffix": "/address@hidden"}}
> > <- { "return": {} }
> >
> > Signed-off-by: Gonglei <address@hidden>
> > Signed-off-by: Chenliang <address@hidden>
> > ---
> >  qapi-schema.json | 16 ++++++++++++++++
> >  qmp-commands.hx  | 24 ++++++++++++++++++++++++
> >  qmp.c            | 17 +++++++++++++++++
> >  3 files changed, 57 insertions(+)
> >
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index b11aad2..a9ef0be 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -1704,6 +1704,22 @@
> >  { 'command': 'device_del', 'data': {'id': 'str'} }
> >
> >  ##
> > +# @set-bootindex:
> > +#
> > +# set bootindex of a devcie
> > +#
> > +# @id: the name of the device
> > +# @bootindex: the bootindex of the device
> > +# @suffix: #optional a suffix of the device
> > +#
> > +# Returns: Nothing on success
> > +#          If @id is not a valid device, DeviceNotFound
> > +#
> > +# Since: 2.2
> > +##
> > +{ 'command': 'set-bootindex', 'data': {'id': 'str', 'bootindex': 'int', 
> > '*suffix':
> 'str'} }
> > +
> > +##
> 
> I wonder if we could simply use qom-set for that. How many devices
> actually support having multiple bootindex entries with different
> suffixes?
> 
AFAICT, the floppy device support two bootindex with different suffixes.

Best regards,
-Gonglei