[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] arm64: 64K pages and > 1024MB guest
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] arm64: 64K pages and > 1024MB guest |
|
Date: |
Fri, 01 Aug 2014 13:41:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
Il 01/08/2014 13:28, Peter Maydell ha scritto:
> Paolo: can you review this? Do we also need to do something
> about the use of TARGET_PAGE_BITS in
> kvm_physical_sync_dirty_bitmap?
No, it should be the host page size, matching
cpu_physical_memory_set_dirty_lebitmap.
> Is it really OK to define
> PAGE_SIZE to TARGET_PAGE_SIZE (it's certainly really
> misleading and suggests the kernel headers could be more
> helpful).
No, it's wrong.
> Basically I think kvm-all.c should almost certainly not be
> using any of the TARGET_PAGE_* constants anywhere.
I agree.
I think the patch is right but, besides these considerations, does this
bug still manifest itself after Andrew fixed the start address of the
device at 0x90010000 (IIRC it was the pl031)?
Paolo