[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 7/8] vl: don't use 'Yoda conditions'
From: |
arei.gonglei |
Subject: |
[Qemu-devel] [PATCH v3 7/8] vl: don't use 'Yoda conditions' |
Date: |
Fri, 1 Aug 2014 15:46:15 +0800 |
From: Gonglei <address@hidden>
imitate nearby code about using '!value' or 'value == NULL'
Signed-off-by: Gonglei <address@hidden>
---
vl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index fe451aa..04c5abd 100644
--- a/vl.c
+++ b/vl.c
@@ -1136,7 +1136,7 @@ static int drive_init_func(QemuOpts *opts, void *opaque)
static int drive_enable_snapshot(QemuOpts *opts, void *opaque)
{
- if (NULL == qemu_opt_get(opts, "snapshot")) {
+ if (qemu_opt_get(opts, "snapshot") == NULL) {
qemu_opt_set(opts, "snapshot", "on");
}
return 0;
@@ -2488,8 +2488,9 @@ static int foreach_device_config(int type, int
(*func)(const char *cmdline))
loc_push_restore(&conf->loc);
rc = func(conf->cmdline);
loc_pop(&conf->loc);
- if (0 != rc)
+ if (rc) {
return rc;
+ }
}
return 0;
}
--
1.7.12.4
- [Qemu-devel] [PATCH v3 5/8] don't use 'Yoda conditions', (continued)
[Qemu-devel] [PATCH v3 3/8] audio: don't use 'Yoda conditions', arei.gonglei, 2014/08/01
[Qemu-devel] [PATCH v3 6/8] spice: don't use 'Yoda conditions', arei.gonglei, 2014/08/01
[Qemu-devel] [PATCH v3 7/8] vl: don't use 'Yoda conditions',
arei.gonglei <=
[Qemu-devel] [PATCH v3 2/8] usb: don't use 'Yoda conditions', arei.gonglei, 2014/08/01
[Qemu-devel] [PATCH v3 4/8] isa-bus: don't use 'Yoda conditions', arei.gonglei, 2014/08/01
Re: [Qemu-devel] [PATCH v3 for-2.2 0/8] don't use Yoda conditions, Michael S. Tsirkin, 2014/08/05
Re: [Qemu-devel] [PATCH v3 for-2.2 0/8] don't use Yoda conditions, Eric Blake, 2014/08/05