Re: [Qemu-devel] [PATCH 26/28] ahci: Add test_hba_spec to ahci-test.

[John Snow]

On 07/31/2014 10:01 AM, Stefan Hajnoczi wrote:
> On Mon, Jul 07, 2014 at 02:18:07PM -0400, John Snow wrote:
> > +    if (bitset(cap, AHCI_CAP_SAM)) {
> > +        g_test_message("Supports AHCI-Only Mode: GHC_AE is Read-Only.");
> > +        assert_bit_set(reg, AHCI_GHC_AE);
> > +    } else {
> > +        g_test_message("Supports AHCI/Legacy mix.");
> > +        assert_bit_clear(reg, AHCI_GHC_AE);
> > +    }
> Let's just assert what QEMU implements.
It was mentioned at least once to me that supporting this would be 
interesting. As I was trying to write a spec test, I don't think this 
conditional is hurting anyone. Certainly if we DO decide to implement a 
mixed-mode device later, who will remember to add this check back here?

Especially since it's not an ugly ifdef like my other "what if" cases, I 
feel like it could stay.