[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 21/28] libqtest: Correct small memory leak.
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 21/28] libqtest: Correct small memory leak. |
Date: |
Thu, 31 Jul 2014 13:39:02 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jul 07, 2014 at 02:18:02PM -0400, John Snow wrote:
> Fixes a small memory leak inside of libqtest.
> After we produce a test path and glib copies the string
> for itself, we should clean up our temporary copy.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> tests/libqtest.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/libqtest.c b/tests/libqtest.c
> index e525e6f..8205e0a 100644
> --- a/tests/libqtest.c
> +++ b/tests/libqtest.c
> @@ -644,6 +644,7 @@ void qtest_add_func(const char *str, void (*fn))
> {
> gchar *path = g_strdup_printf("/%s/%s", qtest_get_arch(), str);
> g_test_add_func(path, fn);
> + free(path);
Glib functions use g_malloc()/g_free(), not malloc()/free(). Since this
string was allocated with g_strdup_printf() it must be freed with
g_free().
pgpfLukKOP_1j.pgp
Description: PGP signature
- Re: [Qemu-devel] [PATCH 16/28] ide: make all commands go through cmd_done, (continued)
- [Qemu-devel] [PATCH 10/28] ide: remove wrong setting of BM_STATUS_INT, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 15/28] ide: stop PIO transfer on errors, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 17/28] ahci: construct PIO Setup FIS for PIO commands, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 18/28] q35: Enable the ioapic device to be seen by qtest., John Snow, 2014/07/07
- [Qemu-devel] [PATCH 21/28] libqtest: Correct small memory leak., John Snow, 2014/07/07
- Re: [Qemu-devel] [PATCH 21/28] libqtest: Correct small memory leak.,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 27/28] ahci: Add test_hba_enable to ahci-test., John Snow, 2014/07/07
- [Qemu-devel] [PATCH 22/28] libqos: Fixes a small memory leak., John Snow, 2014/07/07
- [Qemu-devel] [PATCH 20/28] libqos: Correct memory leak, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 19/28] qtest: Adding qtest_memset and qmemset., John Snow, 2014/07/07
- [Qemu-devel] [PATCH 23/28] ahci: Adding basic functionality qtest., John Snow, 2014/07/07