[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v2 12/12] VMState test: hmp interface for ca
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH RFC v2 12/12] VMState test: hmp interface for cancel mechanism |
|
Date: |
Wed, 30 Jul 2014 07:48:57 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote:
>> Signed-off-by: Sanidhya Kashyap <address@hidden>
>> ---
>> hmp-commands.hx | 14 ++++++++++++++
>> hmp.c | 6 ++++++
>> hmp.h | 1 +
>> 3 files changed, 21 insertions(+)
>
> I don't mind if you squash the QMP and HMP counterpart commands into the
> same patch as one another (throughout the series). Each pair of patches
> are both small enough, and related to the same action, that doing it as
> a combined patch may actually get a better review.
It's okay to squash them when they're small and the interfaces they add
are uncontroversial. Otherwise, I prefer them separate, so I can
concentrate on the QMP interface first, without HMP distractions.