[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/arm/boot: Set PC correctly when loading AArc
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] hw/arm/boot: Set PC correctly when loading AArch64 ELF files |
|
Date: |
Tue, 29 Jul 2014 20:31:29 +0100 |
On 29 July 2014 20:25, Richard Henderson <address@hidden> wrote:
> On 07/25/2014 05:23 AM, Peter Maydell wrote:
>> + env->regs[15] = info->entry & 0xfffffffe;
>
> You'd do well to use a U suffix here, otherwise c89 makes this -2 while c99
> does what you want. Which makes a tiny difference on a 64-bit host.
Given that env->regs[] is uint32_t, does it actually change the final
result? I agree that a U suffix would be a good idea, but given that
the code has been that way since 2009 it seems unlikely that we've
actually got breakage from it...
thanks
-- PMM