[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path f
From: |
Gonglei (Arei) |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function |
Date: |
Mon, 28 Jul 2014 08:37:06 +0000 |
> -----Original Message-----
> From: Gerd Hoffmann [mailto:address@hidden
> Sent: Monday, July 28, 2014 4:31 PM
> Subject: Re: [PATCH v2 1/7] bootindex: add modify_boot_device_path function
>
> Hi,
>
> > > ... because you can just copy the suffix from the old entry here,
> > > instead of expecting the caller pass it in.
> > >
> > Okay, agreed.
> >
> > But we should also think about the situation which a device don't have
> > old entry in global fw_boot_order list.
>
> Throw an error?
>
No. I should firstly use the suffix which the caller pass in IMHO,
just like V3 I have posted, Thanks.
> I think it is ok to allow only *changing* the bootindex.
>
Yes, that's no problem.
Best regards,
-Gonglei
- [Qemu-devel] [PATCH v2 0/7] modify boot order of guest, and take effect after rebooting, arei.gonglei, 2014/07/25
- [Qemu-devel] [PATCH v2 2/7] bootindex: add del_boot_device_path function, arei.gonglei, 2014/07/25
- [Qemu-devel] [PATCH v2 7/7] spapr: fix possible memory leak, arei.gonglei, 2014/07/25
- [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function, arei.gonglei, 2014/07/25
- Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function, Gerd Hoffmann, 2014/07/25
- Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function, Gonglei (Arei), 2014/07/25
- Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function, Gerd Hoffmann, 2014/07/28
- Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function,
Gonglei (Arei) <=
- Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function, Gerd Hoffmann, 2014/07/28
- Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function, Gonglei (Arei), 2014/07/28
- Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function, Gerd Hoffmann, 2014/07/28
- Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function, Gonglei (Arei), 2014/07/28
- Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function, Gonglei (Arei), 2014/07/28
- Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function, Gonglei (Arei), 2014/07/29
[Qemu-devel] [PATCH v2 5/7] qmp: add set-bootindex command, arei.gonglei, 2014/07/25
[Qemu-devel] [PATCH v2 3/7] fw_cfg: add fw_cfg_machine_reset function, arei.gonglei, 2014/07/25
[Qemu-devel] [PATCH v2 4/7] bootindex: delete bootindex when device is removed, arei.gonglei, 2014/07/25