[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/audio/intel-hda: Fix MSI capability address
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH] hw/audio/intel-hda: Fix MSI capability address |
|
Date: |
Mon, 28 Jul 2014 10:13:51 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2014-07-28 10:11, Paolo Bonzini wrote:
> Il 27/07/2014 08:57, Jan Kiszka ha scritto:
>> From: Jan Kiszka <address@hidden>
>>
>> According to ICH9 spec, the MSI capability is located at 0x60. This is
>> important for guest drivers that do not parse the capability chain and
>> use absolute addresses instead.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> ---
>> hw/audio/intel-hda.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c
>> index aa49b47..09c4118 100644
>> --- a/hw/audio/intel-hda.c
>> +++ b/hw/audio/intel-hda.c
>> @@ -1141,7 +1141,7 @@ static int intel_hda_init(PCIDevice *pci)
>> "intel-hda", 0x4000);
>> pci_register_bar(&d->pci, 0, 0, &d->mmio);
>> if (d->msi) {
>> - msi_init(&d->pci, 0x50, 1, true, false);
>> + msi_init(&d->pci, 0x60, 1, true, false);
>> }
>>
>> hda_codec_bus_init(DEVICE(pci), &d->codecs, sizeof(d->codecs),
>>
>
> Does this need a compat property?
Sigh, right, it's guest visible.
Jan
signature.asc
Description: OpenPGP digital signature