Re: [Qemu-devel] [PATCH 7/7] libqos: Added basic virtqueue support to virtio implementation

[Stefan Hajnoczi]

On Thu, Jul 24, 2014 at 08:31:05PM +0200, Marc Marí wrote:
> +static void qvirtio_pci_set_queue_address(QVirtioDevice *d, uint16_t addr)
> +{
> +    QVirtioPCIDevice *dev = (QVirtioPCIDevice *)d;
> +    qpci_io_writel(dev->pdev, dev->addr + QVIRTIO_QUEUE_ADDRESS, addr);
> +}

Why is addr uint16_t?  It should be a 32-bit Page Frame Number).  It's
probably clearer to name it "pfn" instead of "addr" since it's not an
address.

pgpe1AaUPmI0q.pgp
Description: PGP signature