Re: [Qemu-devel] [PATCH v2 for-2.1 2/2] pc: hack for migration compatibility from QEMU 2.0

[Paolo Bonzini]

Il 24/07/2014 18:29, Laszlo Ersek ha scritto:
> I compared this too with its v1 counterpart, and it looks good. I have
> one question (just curiosity): the following paragraph was dropped from
> the commit message -- why?
> 
> -Non-AML tables can change depending on the configuration (especially
> -MADT, SRAT, HPET) but they remain the same between QEMU 2.0 and 2.1,
> -so we only compute our padding based on the sizes of the SSDT and DSDT.
> 
> I think this remains true in v2 as well:
> - "aml_len" and "legacy_aml_len" still "only" cover the DSDT and the
> SSDT, and
> - the non-AML tables (eg. the MADT, now spelled out in the commit
> message), although they may grow with the number of CPUs, continue to
> remain the same between 2.0 and 2.1.
> 
> IOW, I think you could have kept this paragraph if you wanted to. Was it
> an oversight to drop it, or did the paragraph contain something
> incorrect (in v1) that I'm unaware of? Or is it just redundant?

An oversight.  I had added it to the mail before sending it, not
directly in the commit message.  I'll add it back for the pull request
(tomorrow morning).

Paolo