Re: [Qemu-devel] [RFC PATCH 02/17] COLO: introduce an api colo_supported() to indicate COLO support

[Eric Blake]

On 07/23/2014 08:25 AM, Yang Hongyang wrote:
> introduce an api colo_supported() to indicate COLO support, returns
> true if colo supported(configured with --enable-colo).

Space before () in English sentences:
 s/supported(configured/supported (configured/

As I mentioned in the cover letter, defaulting to off is probably a bad
idea; I'd rather default to on or even make it unconditional if it
doesn't negatively affect the code base when not used.

> 
> Signed-off-by: Yang Hongyang <address@hidden>
> ---
>  Makefile.objs                      |  1 +
>  include/migration/migration-colo.h | 18 ++++++++++++++++++
>  migration-colo.c                   | 16 ++++++++++++++++
>  stubs/Makefile.objs                |  1 +
>  stubs/migration-colo.c             | 16 ++++++++++++++++
>  5 files changed, 52 insertions(+)
>  create mode 100644 include/migration/migration-colo.h
>  create mode 100644 migration-colo.c
>  create mode 100644 stubs/migration-colo.c
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature